Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more space level metrics #3590

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Add more space level metrics #3590

merged 2 commits into from
Dec 29, 2021

Conversation

jievince
Copy link
Contributor

Co-authored-by: Yee 2520865+yixinglu@users.noreply.github.com
Co-authored-by: Sophie 84560950+Sophie-Xie@users.noreply.github.com

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@jievince jievince added ready-for-testing PR: ready for the CI test ready for review labels Dec 29, 2021
czpmango
czpmango previously approved these changes Dec 29, 2021
View reviewed changes
@jievince jievince force-pushed the add-space-metrics branch 2 times, most recently from c1f05d8 to 2bfe428 Compare December 29, 2021 09:49
@jievince jievince changed the title Add some space level metrics Add more space level metrics Dec 29, 2021
@czpmango czpmango added this to the v3.0.0 milestone Dec 29, 2021
@yixinglu yixinglu merged commit 6a1c204 into vesoft-inc:master Dec 29, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevermore3 nevermore3 nevermore3 approved these changes

@Aiee Aiee Aiee approved these changes

@yixinglu yixinglu Awaiting requested review from yixinglu

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jievince @nevermore3 @Aiee @czpmango @yixinglu